Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1eed4ec authored by Stephen Warren's avatar Stephen Warren Committed by Linus Walleij
Browse files

pinctrl: error if mapping table's control dev can't be found 



This is a serious error, and the pin control system will not function
correctly if it ends up not programing the mapping table entries into
the HW. Instead of just ignoring this, error out.

Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
[rebased to fit the applied patch series, cast error to pointer]
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent f026fe3d

drivers/pinctrl/core.c

+6 −7
Original line number Diff line number Diff line
@@ -518,13 +518,12 @@ static struct pinctrl *pinctrl_get_locked(struct device *dev, const char *name) 
		 */

		pctldev = get_pinctrl_dev_from_devname(map->ctrl_dev_name);

		if (!pctldev) {

			pr_warning("could not find a pinctrl device for pinmux function %s, fishy, they shall all have one\n",

				   map->function);

			pr_warning("given pinctrl device name: %s",

			dev_err(dev, "unknown pinctrl device %s in map entry",

				map->ctrl_dev_name);



			/* Continue to check the other mappings anyway... */

			continue;

			pinmux_put(p);

			kfree(p);

			/* Eventually, this should trigger deferred probe */

			return ERR_PTR(-ENODEV);

		}



		pr_debug("in map, found pctldev %s to handle function %s",