Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1b9e0d3 authored by Enric Balletbo i Serra's avatar Enric Balletbo i Serra Committed by Mark Brown
Browse files

ASoC: mt8173-max98090: remove the call to snd_soc_jack_add_pins. 



The snd_soc_card_jack_new function can call snd_soc_jack_add_pins for
you, so pass directly the pins struct when you create the new jack.

Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a5de5b74

sound/soc/mediatek/mt8173/mt8173-max98090.c

+4 −10
Original line number Diff line number Diff line
@@ -79,17 +79,11 @@ static int mt8173_max98090_init(struct snd_soc_pcm_runtime *runtime) 


	/* enable jack detection */

	ret = snd_soc_card_jack_new(card, "Headphone", SND_JACK_HEADPHONE,

				    &mt8173_max98090_jack, NULL, 0);

				    &mt8173_max98090_jack,

				    mt8173_max98090_jack_pins,

				    ARRAY_SIZE(mt8173_max98090_jack_pins));

	if (ret) {

		dev_err(card->dev, "Can't snd_soc_jack_new %d\n", ret);

		return ret;

	}



	ret = snd_soc_jack_add_pins(&mt8173_max98090_jack,

				    ARRAY_SIZE(mt8173_max98090_jack_pins),

				    mt8173_max98090_jack_pins);

	if (ret) {

		dev_err(card->dev, "Can't snd_soc_jack_add_pins %d\n", ret);

		dev_err(card->dev, "Can't create a new Jack %d\n", ret);

		return ret;

	}