Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0471bb7 authored by Yan Burman's avatar Yan Burman Committed by John W. Linville
Browse files

[PATCH] hostap: replace kmalloc+memset with kzalloc 



Replace kmalloc+memset with kzalloc

Signed-off-by: default avatarYan Burman <burman.yan@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 9cdac965

drivers/net/wireless/hostap/hostap_ap.c

+1 −3
Original line number Diff line number Diff line
@@ -1099,15 +1099,13 @@ static struct sta_info * ap_add_sta(struct ap_data *ap, u8 *addr) 
{

	struct sta_info *sta;



	sta = (struct sta_info *)

		kmalloc(sizeof(struct sta_info), GFP_ATOMIC);

	sta = kzalloc(sizeof(struct sta_info), GFP_ATOMIC);

	if (sta == NULL) {

		PDEBUG(DEBUG_AP, "AP: kmalloc failed\n");

		return NULL;

	}



	/* initialize STA info data */

	memset(sta, 0, sizeof(struct sta_info));

	sta->local = ap->local;

	skb_queue_head_init(&sta->tx_buf);

	memcpy(sta->addr, addr, ETH_ALEN);

drivers/net/wireless/hostap/hostap_cs.c

+1 −2
Original line number Diff line number Diff line
@@ -566,12 +566,11 @@ static int prism2_config(struct pcmcia_device *link) 
	PDEBUG(DEBUG_FLOW, "prism2_config()\n");



	parse = kmalloc(sizeof(cisparse_t), GFP_KERNEL);

	hw_priv = kmalloc(sizeof(*hw_priv), GFP_KERNEL);

	hw_priv = kzalloc(sizeof(*hw_priv), GFP_KERNEL);

	if (parse == NULL || hw_priv == NULL) {

		ret = -ENOMEM;

		goto failed;

	}

	memset(hw_priv, 0, sizeof(*hw_priv));



	tuple.DesiredTuple = CISTPL_CONFIG;

	tuple.Attributes = 0;

drivers/net/wireless/hostap/hostap_download.c

+1 −3
Original line number Diff line number Diff line
@@ -685,14 +685,12 @@ static int prism2_download(local_info_t *local, 
		goto out;

	}



	dl = kmalloc(sizeof(*dl) + param->num_areas *

	dl = kzalloc(sizeof(*dl) + param->num_areas *

		     sizeof(struct prism2_download_data_area), GFP_KERNEL);

	if (dl == NULL) {

		ret = -ENOMEM;

		goto out;

	}

	memset(dl, 0, sizeof(*dl) + param->num_areas *

	       sizeof(struct prism2_download_data_area));

	dl->dl_cmd = param->dl_cmd;

	dl->start_addr = param->start_addr;

	dl->num_areas = param->num_areas;

drivers/net/wireless/hostap/hostap_hw.c

+3 −9
Original line number Diff line number Diff line
@@ -347,14 +347,12 @@ static int hfa384x_cmd(struct net_device *dev, u16 cmd, u16 param0, 
	if (signal_pending(current))

		return -EINTR;



	entry = (struct hostap_cmd_queue *)

		kmalloc(sizeof(*entry), GFP_ATOMIC);

	entry = kzalloc(sizeof(*entry), GFP_ATOMIC);

	if (entry == NULL) {

		printk(KERN_DEBUG "%s: hfa384x_cmd - kmalloc failed\n",

		       dev->name);

		return -ENOMEM;

	}

	memset(entry, 0, sizeof(*entry));

	atomic_set(&entry->usecnt, 1);

	entry->type = CMD_SLEEP;

	entry->cmd = cmd;
@@ -517,14 +515,12 @@ static int hfa384x_cmd_callback(struct net_device *dev, u16 cmd, u16 param0, 
		return -1;

	}



	entry = (struct hostap_cmd_queue *)

		kmalloc(sizeof(*entry), GFP_ATOMIC);

	entry = kzalloc(sizeof(*entry), GFP_ATOMIC);

	if (entry == NULL) {

		printk(KERN_DEBUG "%s: hfa384x_cmd_callback - kmalloc "

		       "failed\n", dev->name);

		return -ENOMEM;

	}

	memset(entry, 0, sizeof(*entry));

	atomic_set(&entry->usecnt, 1);

	entry->type = CMD_CALLBACK;

	entry->cmd = cmd;
@@ -3015,14 +3011,12 @@ static int prism2_set_tim(struct net_device *dev, int aid, int set) 
	iface = netdev_priv(dev);

	local = iface->local;



	new_entry = (struct set_tim_data *)

		kmalloc(sizeof(*new_entry), GFP_ATOMIC);

	new_entry = kzalloc(sizeof(*new_entry), GFP_ATOMIC);

	if (new_entry == NULL) {

		printk(KERN_DEBUG "%s: prism2_set_tim: kmalloc failed\n",

		       local->dev->name);

		return -ENOMEM;

	}

	memset(new_entry, 0, sizeof(*new_entry));

	new_entry->aid = aid;

	new_entry->set = set;

drivers/net/wireless/hostap/hostap_info.c

+1 −2
Original line number Diff line number Diff line
@@ -327,11 +327,10 @@ static void prism2_info_hostscanresults(local_info_t *local, 
	ptr = (u8 *) pos;



	new_count = left / result_size;

	results = kmalloc(new_count * sizeof(struct hfa384x_hostscan_result),

	results = kcalloc(new_count, sizeof(struct hfa384x_hostscan_result),

			  GFP_ATOMIC);

	if (results == NULL)

		return;

	memset(results, 0, new_count * sizeof(struct hfa384x_hostscan_result));



	for (i = 0; i < new_count; i++) {

		memcpy(&results[i], ptr, copy_len);