Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b01079be authored by Geliang Tang's avatar Geliang Tang Committed by Alexandre Belloni
Browse files

rtc: fix module reference count in rtc-proc 



rtc-proc.c is not built as a module. Thus, rather than dealing with
THIS_MODULE's reference count, we should deal with rtc->owner's
reference count.

Signed-off-by: default avatarGeliang Tang <geliangtang@163.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent fbbf53f7

drivers/rtc/rtc-proc.c

+5 −3
Original line number Diff line number Diff line
@@ -112,19 +112,21 @@ static int rtc_proc_open(struct inode *inode, struct file *file) 
	int ret;

	struct rtc_device *rtc = PDE_DATA(inode);



	if (!try_module_get(THIS_MODULE))

	if (!try_module_get(rtc->owner))

		return -ENODEV;



	ret = single_open(file, rtc_proc_show, rtc);

	if (ret)

		module_put(THIS_MODULE);

		module_put(rtc->owner);

	return ret;

}



static int rtc_proc_release(struct inode *inode, struct file *file)

{

	int res = single_release(inode, file);

	module_put(THIS_MODULE);

	struct rtc_device *rtc = PDE_DATA(inode);



	module_put(rtc->owner);

	return res;

}