Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aebac744 authored by Fabio Estevam's avatar Fabio Estevam Committed by David S. Miller
Browse files

fec: Remove fec_enet_select_queue() 

Sparse complains about fec_enet_select_queue() not being static.

Feedback from David Miller [1] was to remove this function instead of making it
static:

"Please just delete this function.

It's overriding code which does exactly the same thing.

Actually, more precisely, this code is duplicating code in a way that
bypasses many core facilitites of the networking.  For example, this
override means that socket based flow steering, XPS, etc. are all
not happening on these devices.

Without ->ndo_select_queue(), the flow dissector does __netdev_pick_tx
which is exactly what you want to happen."

[1] http://www.spinics.net/lists/netdev/msg297653.html



Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 57219dc7

drivers/net/ethernet/freescale/fec_main.c

+0 −7
Original line number Diff line number Diff line
@@ -2851,17 +2851,10 @@ static int fec_set_features(struct net_device *netdev, 
	return 0;

}



u16 fec_enet_select_queue(struct net_device *ndev, struct sk_buff *skb,

			  void *accel_priv, select_queue_fallback_t fallback)

{

	return skb_tx_hash(ndev, skb);

}



static const struct net_device_ops fec_netdev_ops = {

	.ndo_open		= fec_enet_open,

	.ndo_stop		= fec_enet_close,

	.ndo_start_xmit		= fec_enet_start_xmit,

	.ndo_select_queue       = fec_enet_select_queue,

	.ndo_set_rx_mode	= set_multicast_list,

	.ndo_change_mtu		= eth_change_mtu,

	.ndo_validate_addr	= eth_validate_addr,