Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae9550f6 authored by Magnus Damm's avatar Magnus Damm Committed by Linus Walleij
Browse files

gpio-rcar: Use OUTDT when reading GPIOs configured as output 



Testing on r8a7790 shows that INDT does not indicate the correct
pin state when reading a GPIO configured as output, so update
the gpio_rcar_get() function to handle this case.

Signed-off-by: default avatarMagnus Damm <damm@opensource.se>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent cd738916

drivers/gpio/gpio-rcar.c

+8 −1
Original line number Diff line number Diff line
@@ -214,7 +214,14 @@ static int gpio_rcar_direction_input(struct gpio_chip *chip, unsigned offset) 


static int gpio_rcar_get(struct gpio_chip *chip, unsigned offset)

{

	return (int)(gpio_rcar_read(gpio_to_priv(chip), INDT) & BIT(offset));

	u32 bit = BIT(offset);



	/* testing on r8a7790 shows that INDT does not show correct pin state

	 * when configured as output, so use OUTDT in case of output pins */

	if (gpio_rcar_read(gpio_to_priv(chip), INOUTSEL) & bit)

		return (int)(gpio_rcar_read(gpio_to_priv(chip), OUTDT) & bit);

	else

		return (int)(gpio_rcar_read(gpio_to_priv(chip), INDT) & bit);

}



static void gpio_rcar_set(struct gpio_chip *chip, unsigned offset, int value)