Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adddcac0 authored by Brian Norris's avatar Brian Norris
Browse files

mtd: lpc32xx: drop bitflip_threshold initialization 



These drivers don't need to explicitly initialize their bitflip
thresholds. The comment is no longer correct, since nand_scan_tail()
performs this initialization as of the following commit:

    commit ea3b2ea2
    Author: Shmulik Ladkani <shmulik@jungo.com>
    Date:   Fri Jun 8 18:29:06 2012 +0300

        mtd: nand: initialize bitflip_threshold prior to BBT scanning

(It seems there were some parallel efforts on writing/submitting these
drivers, and Shmulik's bug fix.)

Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
Cc: Roland Stigge <stigge@antcom.de>
parent 7171511e

drivers/mtd/nand/lpc32xx_mlc.c

+0 −6
Original line number Diff line number Diff line
@@ -721,12 +721,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev) 
	nand_chip->bbt_td = &lpc32xx_nand_bbt;

	nand_chip->bbt_md = &lpc32xx_nand_bbt_mirror;



	/* bitflip_threshold's default is defined as ecc_strength anyway.

	 * Unfortunately, it is set only later at add_mtd_device(). Meanwhile

	 * being 0, it causes bad block table scanning errors in

	 * nand_scan_tail(), so preparing it here. */

	mtd->bitflip_threshold = nand_chip->ecc.strength;



	if (use_dma) {

		res = lpc32xx_dma_setup(host);

		if (res) {

drivers/mtd/nand/lpc32xx_slc.c

+0 −6
Original line number Diff line number Diff line
@@ -840,12 +840,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev) 
	chip->ecc.strength = 1;

	chip->ecc.hwctl = lpc32xx_nand_ecc_enable;



	/* bitflip_threshold's default is defined as ecc_strength anyway.

	 * Unfortunately, it is set only later at add_mtd_device(). Meanwhile

	 * being 0, it causes bad block table scanning errors in

	 * nand_scan_tail(), so preparing it here already. */

	mtd->bitflip_threshold = chip->ecc.strength;



	/*

	 * Allocate a large enough buffer for a single huge page plus

	 * extra space for the spare area and ECC storage area