Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit add78fc0 authored by Vivek Gautam's avatar Vivek Gautam Committed by Martin K. Petersen
Browse files

phy: qcom-ufs: Use devm sibling of kstrdup for regulator names 



This helps us in avoiding any requirement for kfree() operation
to be called exclusively over the allocated string pointer.

Signed-off-by: default avatarVivek Gautam <vivek.gautam@codeaurora.org>
Reviewed-by: default avatarSubhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent fd91ddad

drivers/phy/phy-qcom-ufs.c

+1 −4
Original line number Diff line number Diff line
@@ -251,7 +251,7 @@ static int __ufs_qcom_phy_init_vreg(struct phy *phy, 


	char prop_name[MAX_PROP_NAME];



	vreg->name = kstrdup(name, GFP_KERNEL);

	vreg->name = devm_kstrdup(dev, name, GFP_KERNEL);

	if (!vreg->name) {

		err = -ENOMEM;

		goto out;
@@ -637,9 +637,6 @@ int ufs_qcom_phy_remove(struct phy *generic_phy, 
{

	phy_power_off(generic_phy);



	kfree(ufs_qcom_phy->vdda_pll.name);

	kfree(ufs_qcom_phy->vdda_phy.name);



	return 0;

}

EXPORT_SYMBOL_GPL(ufs_qcom_phy_remove);