Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad149b6e authored by Adam McCoy's avatar Adam McCoy Committed by Greg Kroah-Hartman
Browse files

cifs: fix leaked reference on requeued write



commit a48137996063d22ffba77e077425f49873856ca5 upstream.

Failed async writes that are requeued may not clean up a refcount
on the file, which can result in a leaked open. This scenario arises
very reliably when using persistent handles and a reconnect occurs
while writing.

cifs_writev_requeue only releases the reference if the write fails
(rc != 0). The server->ops->async_writev operation will take its own
reference, so the initial reference can always be released.

Signed-off-by: default avatarAdam McCoy <adam@forsedomani.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
CC: Stable <stable@vger.kernel.org>
Reviewed-by: default avatarPavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 643ca709
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -2051,8 +2051,8 @@ cifs_writev_requeue(struct cifs_writedata *wdata)
			}
		}

		if (rc) {
		kref_put(&wdata2->refcount, cifs_writedata_release);
		if (rc) {
			if (is_retryable_error(rc))
				continue;
			i += nr_pages;