Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad008d42 authored by Adrian Bunk's avatar Adrian Bunk Committed by James Bottomley
Browse files

[SCSI] mptbase: fix use-after-free's 



ioc->name is used in the printk's after ioc has been freed.  Free
after prinks to fix this.

This patch fixes two use-after-free's introduced by
commit e78d5b8f and spotted by the
Coverity checker.

Signed-off-by: default avatarAdrian Bunk <bunk@kernel.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 3b0f208a

drivers/message/fusion/mptbase.c

+2 −2
Original line number Diff line number Diff line
@@ -1481,15 +1481,15 @@ mpt_attach(struct pci_dev *pdev, const struct pci_device_id *id) 


	ioc->bars = pci_select_bars(pdev, IORESOURCE_MEM);

	if (pci_enable_device_mem(pdev)) {

		kfree(ioc);

		printk(MYIOC_s_ERR_FMT "pci_enable_device_mem() "

		       "failed\n", ioc->name);

		kfree(ioc);

		return r;

	}

	if (pci_request_selected_regions(pdev, ioc->bars, "mpt")) {

		kfree(ioc);

		printk(MYIOC_s_ERR_FMT "pci_request_selected_regions() with "

		       "MEM failed\n", ioc->name);

		kfree(ioc);

		return r;

	}