Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acf8ab9a authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Martin K. Petersen
Browse files

scsi: ses: check return code from ses_recv_diag() 



We should be checking the return code from ses_recv_diag() to avoid
accessing invalid data.

Signed-off-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c8cd71f1

drivers/scsi/ses.c

+2 −1
Original line number Diff line number Diff line
@@ -179,7 +179,8 @@ static unsigned char *ses_get_page2_descriptor(struct enclosure_device *edev, 
	unsigned char *type_ptr = ses_dev->page1_types;

	unsigned char *desc_ptr = ses_dev->page2 + 8;



	ses_recv_diag(sdev, 2, ses_dev->page2, ses_dev->page2_len);

	if (ses_recv_diag(sdev, 2, ses_dev->page2, ses_dev->page2_len) < 0)

		return NULL;



	for (i = 0; i < ses_dev->page1_num_types; i++, type_ptr += 4) {

		for (j = 0; j < type_ptr[1]; j++) {