Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ace27355 authored by Amitkumar Karwar's avatar Amitkumar Karwar Committed by John W. Linville
Browse files

mwifiex: skipping pending commands after unload 



We skip downloading other commands after FUNC_SHUTDOWN is queued
during driver unload. Main thread should be woken up each time
after freeing skipped command so that FUNC_SHUTDOWN gets served
in case if there are other pending commands before FUNC_SHUTDOWN.
Also, call mwifiex_complete_cmd() only for synchronous commands.

Reported-by: default avatarAvery Pennarun <apenwarr@gmail.com>
Signed-off-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarMaithili Hinge <maithili@marvell.com>
Signed-off-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 4af2bd49

drivers/net/wireless/mwifiex/cmdevt.c

+3 −1
Original line number Diff line number Diff line
@@ -165,8 +165,10 @@ static int mwifiex_dnld_cmd_to_fw(struct mwifiex_private *priv, 
		dev_err(adapter->dev,

			"DNLD_CMD: FW in reset state, ignore cmd %#x\n",

			cmd_code);

		if (cmd_node->wait_q_enabled)

			mwifiex_complete_cmd(adapter, cmd_node);

		mwifiex_recycle_cmd_node(adapter, cmd_node);

		queue_work(adapter->workqueue, &adapter->main_work);

		return -1;

	}