Commit ac904ac8 authored Jun 10, 2014 by Pablo Neira Ayuso

netfilter: nf_tables: fix wrong type in transaction when replacing rules

In b380e5c7 ("netfilter: nf_tables: add message type to transactions"),
I used the wrong message type in the rule replacement case. The rule
that is replaced needs to be handled as a deleted rule.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent ac34b861

net/netfilter/nf_tables_api.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1792,7 +1792,7 @@ static int nf_tables_newrule(struct sock nlsk, struct sk_buff skb,

		if (nlh->nlmsg_flags & NLM_F_REPLACE) {
		if (nft_rule_is_active_next(net, old_rule)) {
		trans = nft_trans_rule_add(&ctx, NFT_MSG_NEWRULE,
		trans = nft_trans_rule_add(&ctx, NFT_MSG_DELRULE,
		old_rule);
		if (trans == NULL) {
		err = -ENOMEM;