Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac8e35b2 authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck
Browse files

hwmon: (adt7x10) use permission-specific DEVICE_ATTR variants 



Use DEVICE_ATTR_RO for read only attributes and DEVICE_ATTR_RW for
read/write attributes. This simplifies the source code, improves
readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 808fc6c2

drivers/hwmon/adt7x10.c

+3 −4
Original line number Diff line number Diff line
@@ -331,8 +331,7 @@ static ssize_t adt7x10_show_alarm(struct device *dev, 
	return sprintf(buf, "%d\n", !!(ret & attr->index));

}



static ssize_t adt7x10_show_name(struct device *dev,

				 struct device_attribute *da,

static ssize_t name_show(struct device *dev, struct device_attribute *da,

			 char *buf)

{

	struct adt7x10_data *data = dev_get_drvdata(dev);
@@ -359,7 +358,7 @@ static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, adt7x10_show_alarm, 
			  NULL, ADT7X10_STAT_T_HIGH);

static SENSOR_DEVICE_ATTR(temp1_crit_alarm, S_IRUGO, adt7x10_show_alarm,

			  NULL, ADT7X10_STAT_T_CRIT);

static DEVICE_ATTR(name, S_IRUGO, adt7x10_show_name, NULL);

static DEVICE_ATTR_RO(name);



static struct attribute *adt7x10_attributes[] = {

	&sensor_dev_attr_temp1_input.dev_attr.attr,