Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac8a103e authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Greg Kroah-Hartman
Browse files

serial: sh-sci: Drop superfluous assignment in sci_request_dma() 



No later code uses the assigned value, so it can be dropped.

Reported-by: default avatarSimon Horman <horms@verge.net.au>
Fixes: 2c4ee235 ("serial: sh-sci: Postpone DMA release when falling back to PIO")
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 26f22d57

drivers/tty/serial/sh-sci.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -1574,7 +1574,6 @@ static void sci_request_dma(struct uart_port *port) 
		if (dma_mapping_error(chan->device->dev, s->tx_dma_addr)) {

		if (dma_mapping_error(chan->device->dev, s->tx_dma_addr)) {

			dev_warn(port->dev, "Failed mapping Tx DMA descriptor\n");

			dev_warn(port->dev, "Failed mapping Tx DMA descriptor\n");

			dma_release_channel(chan);

			dma_release_channel(chan);

			chan = NULL;

		} else {

		} else {

			dev_dbg(port->dev, "%s: mapped %lu@%p to %pad\n",

			dev_dbg(port->dev, "%s: mapped %lu@%p to %pad\n",

				__func__, UART_XMIT_SIZE,

				__func__, UART_XMIT_SIZE,