Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac69c26e authored by Wei Liu's avatar Wei Liu Committed by David S. Miller
Browse files

xen-netback: remove redundent parameter in netbk_count_requests 



Tracking down from the caller, first_idx is always equal to vif->tx.req_cons.
Remove it to avoid confusion.

Suggested-by: default avatarJan Beulich <jbeulich@suse.com>
Signed-off-by: default avatarWei Liu <wei.liu2@citrix.com>
Acked-by: default avatarIan Campbell <ian.campbell@citrix.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c2bba3df

drivers/net/xen-netback/netback.c

+2 −4
Original line number Diff line number Diff line
@@ -928,7 +928,6 @@ static void netbk_fatal_tx_err(struct xenvif *vif) 


static int netbk_count_requests(struct xenvif *vif,

				struct xen_netif_tx_request *first,

				RING_IDX first_idx,

				struct xen_netif_tx_request *txp,

				int work_to_do)

{
@@ -1005,7 +1004,7 @@ static int netbk_count_requests(struct xenvif *vif, 
	} while ((txp++)->flags & XEN_NETTXF_more_data);



	if (drop_err) {

		netbk_tx_err(vif, first, first_idx + slots);

		netbk_tx_err(vif, first, cons + slots);

		return drop_err;

	}
@@ -1470,8 +1469,7 @@ static unsigned xen_netbk_tx_build_gops(struct xen_netbk *netbk) 
				continue;

		}



		ret = netbk_count_requests(vif, &txreq, idx,

					   txfrags, work_to_do);

		ret = netbk_count_requests(vif, &txreq, txfrags, work_to_do);

		if (unlikely(ret < 0))

			continue;