Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac1ecece authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

i7core_edac: Add support for X5670 



As reported by Vernon Mauery <vernux@us.ibm.com>, X5670 (Westmere-EP) uses a
different register for one of the uncore PCI devices. Add support for
it.

Those are the PCI ID's on this new chipset:

fe:00.0 0600: 8086:2c70 (rev 02)
fe:00.1 0600: 8086:2d81 (rev 02)
fe:02.0 0600: 8086:2d90 (rev 02)
fe:02.1 0600: 8086:2d91 (rev 02)
fe:02.2 0600: 8086:2d92 (rev 02)
fe:02.3 0600: 8086:2d93 (rev 02)
fe:02.4 0600: 8086:2d94 (rev 02)
fe:02.5 0600: 8086:2d95 (rev 02)
fe:03.0 0600: 8086:2d98 (rev 02)
fe:03.1 0600: 8086:2d99 (rev 02)
fe:03.2 0600: 8086:2d9a (rev 02)
fe:03.4 0600: 8086:2d9c (rev 02)
fe:04.0 0600: 8086:2da0 (rev 02)
fe:04.1 0600: 8086:2da1 (rev 02)
fe:04.2 0600: 8086:2da2 (rev 02)
fe:04.3 0600: 8086:2da3 (rev 02)
fe:05.0 0600: 8086:2da8 (rev 02)
fe:05.1 0600: 8086:2da9 (rev 02)
fe:05.2 0600: 8086:2daa (rev 02)
fe:05.3 0600: 8086:2dab (rev 02)
fe:06.0 0600: 8086:2db0 (rev 02)
fe:06.1 0600: 8086:2db1 (rev 02)
fe:06.2 0600: 8086:2db2 (rev 02)
fe:06.3 0600: 8086:2db3 (rev 02)
(as usual, the same PCI devices repeat at ff: bus)

The PCI device 8086:2c70 is shown as:

fe:00.0 Host bridge: Intel Corporation QuickPath Architecture Generic
Non-core Registers (rev 02)

So, for this device to be recognized, it is only a matter of adding this
new PCI ID to the driver.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 8a311e17

drivers/edac/i7core_edac.c

+6 −1
Original line number Diff line number Diff line
@@ -1213,10 +1213,15 @@ int i7core_get_onedevice(struct pci_dev **prev, int devno, 
		pdev = pci_get_device(PCI_VENDOR_ID_INTEL,

				      PCI_DEVICE_ID_INTEL_I7_NONCORE_ALT, *prev);



	if (dev_descr->dev_id == PCI_DEVICE_ID_INTEL_LYNNFIELD_NONCORE && !pdev)

	if (dev_descr->dev_id == PCI_DEVICE_ID_INTEL_LYNNFIELD_NONCORE && !pdev) {

		pdev = pci_get_device(PCI_VENDOR_ID_INTEL,

				      PCI_DEVICE_ID_INTEL_LYNNFIELD_NONCORE_ALT,

				      *prev);

		if (!pdev)

			pdev = pci_get_device(PCI_VENDOR_ID_INTEL,

					      PCI_DEVICE_ID_INTEL_LYNNFIELD_NONCORE_REV2,

					      *prev);

	}



	if (!pdev) {

		if (*prev) {

include/linux/pci_ids.h

+1 −0
Original line number Diff line number Diff line
@@ -2552,6 +2552,7 @@ 
#define PCI_DEVICE_ID_INTEL_I7_NONCORE_ALT 0x2c40

#define PCI_DEVICE_ID_INTEL_LYNNFIELD_NONCORE     0x2c50

#define PCI_DEVICE_ID_INTEL_LYNNFIELD_NONCORE_ALT 0x2c51

#define PCI_DEVICE_ID_INTEL_LYNNFIELD_NONCORE_REV2 0x2c70

#define PCI_DEVICE_ID_INTEL_LYNNFIELD_SAD         0x2c81

#define PCI_DEVICE_ID_INTEL_LYNNFIELD_QPI_LINK0   0x2c90

#define PCI_DEVICE_ID_INTEL_LYNNFIELD_QPI_PHY0    0x2c91