Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit abd1026d authored by Vitaly Kuznetsov's avatar Vitaly Kuznetsov Committed by Greg Kroah-Hartman
Browse files

hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() 



"kernel BUG at drivers/hv/channel_mgmt.c:350!" is observed when hv_vmbus
module is unloaded. BUG_ON() was introduced in commit 85d9aa70
("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()") as
vmbus_free_channels() codepath was apparently forgotten.

Fixes: 85d9aa70 ("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()")

Signed-off-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f45be72c

drivers/hv/channel_mgmt.c

+2 −0
Original line number Diff line number Diff line
@@ -389,6 +389,7 @@ void vmbus_free_channels(void) 
{

	struct vmbus_channel *channel, *tmp;



	mutex_lock(&vmbus_connection.channel_mutex);

	list_for_each_entry_safe(channel, tmp, &vmbus_connection.chn_list,

		listentry) {

		/* hv_process_channel_removal() needs this */
@@ -396,6 +397,7 @@ void vmbus_free_channels(void) 


		vmbus_device_unregister(channel->device_obj);

	}

	mutex_unlock(&vmbus_connection.channel_mutex);

}



/*