Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a92bf307 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

drm/bridge: ps8622: Pass flags to devm_gpiod_get() 



Since 39b2bbe3 (gpio: add flags argument to gpiod_get*() functions)
which appeared in v3.17-rc1, the gpiod_get* functions take an additional
parameter that allows to specify direction and initial value for output.

Use this to simplify the driver. Furthermore this is one caller less
that stops us making the flags argument to gpiod_get*() mandatory.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 394e5b6d

drivers/gpu/drm/bridge/ps8622.c

+5 −15
Original line number Diff line number Diff line
@@ -581,31 +581,21 @@ static int ps8622_probe(struct i2c_client *client, 
		ps8622->v12 = NULL;

	}



	ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");

	ps8622->gpio_slp = devm_gpiod_get(dev, "sleep", GPIOD_OUT_HIGH);

	if (IS_ERR(ps8622->gpio_slp)) {

		ret = PTR_ERR(ps8622->gpio_slp);

		dev_err(dev, "cannot get gpio_slp %d\n", ret);

		return ret;

	}

	ret = gpiod_direction_output(ps8622->gpio_slp, 1);

	if (ret) {

		dev_err(dev, "cannot configure gpio_slp\n");

		return ret;

	}



	ps8622->gpio_rst = devm_gpiod_get(dev, "reset");

	if (IS_ERR(ps8622->gpio_rst)) {

		ret = PTR_ERR(ps8622->gpio_rst);

		dev_err(dev, "cannot get gpio_rst %d\n", ret);

		return ret;

	}

	/*

	 * Assert the reset pin high to avoid the bridge being

	 * initialized prematurely

	 */

	ret = gpiod_direction_output(ps8622->gpio_rst, 1);

	if (ret) {

		dev_err(dev, "cannot configure gpio_rst\n");

	ps8622->gpio_rst = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);

	if (IS_ERR(ps8622->gpio_rst)) {

		ret = PTR_ERR(ps8622->gpio_rst);

		dev_err(dev, "cannot get gpio_rst %d\n", ret);

		return ret;

	}