Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a911fd9a authored by Chuck Lever's avatar Chuck Lever Committed by Trond Myklebust
Browse files

NFS: simplify inlined bit ops in nfs_page.h 



 Minor cleanup:  inlined bit ops in nfs_page.h can be simpler.

 Test plan:
 Write-intensive workload against a server that requires COMMITs.

 Signed-off-by: default avatarChuck Lever <cel@netapp.com>
 Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 6b59a754

include/linux/nfs_page.h

+3 −9
Original line number Diff line number Diff line
@@ -79,9 +79,7 @@ extern void nfs_clear_page_writeback(struct nfs_page *req); 
static inline int

nfs_lock_request_dontget(struct nfs_page *req)

{

	if (test_and_set_bit(PG_BUSY, &req->wb_flags))

		return 0;

	return 1;

	return !test_and_set_bit(PG_BUSY, &req->wb_flags);

}



/*
@@ -125,9 +123,7 @@ nfs_list_remove_request(struct nfs_page *req) 
static inline int

nfs_defer_commit(struct nfs_page *req)

{

	if (test_and_set_bit(PG_NEED_COMMIT, &req->wb_flags))

		return 0;

	return 1;

	return !test_and_set_bit(PG_NEED_COMMIT, &req->wb_flags);

}



static inline void
@@ -141,9 +137,7 @@ nfs_clear_commit(struct nfs_page *req) 
static inline int

nfs_defer_reschedule(struct nfs_page *req)

{

	if (test_and_set_bit(PG_NEED_RESCHED, &req->wb_flags))

		return 0;

	return 1;

	return !test_and_set_bit(PG_NEED_RESCHED, &req->wb_flags);

}



static inline void