Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a84a49d5 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Tomi Valkeinen
Browse files

drm: omapdrm: panel-lgphilips-lb035q02: Remove unused backlight GPIO 



The backlight GPIO was supported with platform data only. Now that the
driver only supports DT, the backlight GPIO is never initialized. Remove
it.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 5379be29

drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c

+0 −19
Original line number Diff line number Diff line
@@ -51,9 +51,6 @@ struct panel_drv_data { 


	struct omap_video_timings videomode;



	/* used for non-DT boot, to be removed */

	int backlight_gpio;



	struct gpio_desc *enable_gpio;

};
@@ -171,9 +168,6 @@ static int lb035q02_enable(struct omap_dss_device *dssdev) 
	if (ddata->enable_gpio)

		gpiod_set_value_cansleep(ddata->enable_gpio, 1);



	if (gpio_is_valid(ddata->backlight_gpio))

		gpio_set_value_cansleep(ddata->backlight_gpio, 1);



	dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;



	return 0;
@@ -190,9 +184,6 @@ static void lb035q02_disable(struct omap_dss_device *dssdev) 
	if (ddata->enable_gpio)

		gpiod_set_value_cansleep(ddata->enable_gpio, 0);



	if (gpio_is_valid(ddata->backlight_gpio))

		gpio_set_value_cansleep(ddata->backlight_gpio, 0);



	in->ops.dpi->disable(in);



	dssdev->state = OMAP_DSS_DISPLAY_DISABLED;
@@ -256,8 +247,6 @@ static int lb035q02_probe_of(struct spi_device *spi) 


	ddata->enable_gpio = gpio;



	ddata->backlight_gpio = -ENOENT;



	in = omapdss_of_find_source_for_first_ep(node);

	if (IS_ERR(in)) {

		dev_err(&spi->dev, "failed to find video source\n");
@@ -290,13 +279,6 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi) 
	if (r)

		return r;



	if (gpio_is_valid(ddata->backlight_gpio)) {

		r = devm_gpio_request_one(&spi->dev, ddata->backlight_gpio,

				GPIOF_OUT_INIT_LOW, "panel backlight");

		if (r)

			goto err_gpio;

	}



	ddata->videomode = lb035q02_timings;



	dssdev = &ddata->dssdev;
@@ -316,7 +298,6 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi) 
	return 0;



err_reg:

err_gpio:

	omap_dss_put_device(ddata->in);

	return r;

}