Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a844b43c authored by Axel Lin's avatar Axel Lin Committed by Linus Torvalds
Browse files

drivers/misc/atmel_tclib.c: fix a memory leak 



request_mem_region() will call kzalloc to allocate memory for struct
resource.  release_resource() unregisters the resource but does not free
the allocated memory, thus use release_mem_region() instead to fix the
memory leak.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6f7d485e

drivers/misc/atmel_tclib.c

+2 −2
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ struct atmel_tc *atmel_tc_alloc(unsigned block, const char *name) 
	return tc;



fail_ioremap:

	release_resource(r);

	release_mem_region(r->start, ATMEL_TC_IOMEM_SIZE);

fail:

	tc = NULL;

	goto out;
@@ -95,7 +95,7 @@ void atmel_tc_free(struct atmel_tc *tc) 
	spin_lock(&tc_list_lock);

	if (tc->regs) {

		iounmap(tc->regs);

		release_resource(tc->iomem);

		release_mem_region(tc->iomem->start, ATMEL_TC_IOMEM_SIZE);

		tc->regs = NULL;

		tc->iomem = NULL;

	}