Commit a7fbf6bb authored Apr 10, 2006 by Cornelia Huck Committed by Linus Torvalds Apr 11, 2006

[PATCH] s390: wrong return codes in cio_ignore_proc_init()



cio_ignore_proc_init() returns 1 in case of success and 0 in case of failure.
The caller tests for != 0, so better return 0 in case of success and -ENOENT
in case of failure.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent da074d0a

drivers/s390/cio/blacklist.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -414,11 +414,11 @@ cio_ignore_proc_init (void)
		entry = create_proc_entry ("cio_ignore", S_IFREG \| S_IRUGO \| S_IWUSR,
		&proc_root);
		if (!entry)
		return 0;
		return -ENOENT;

		entry->proc_fops = &cio_ignore_proc_fops;

		return 1;
		return 0;
		}

		__initcall (cio_ignore_proc_init);