Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7f4b988 authored by Ivan Vecera's avatar Ivan Vecera Committed by David S. Miller
Browse files

bna: fix list corruption 



Use list_move_tail() to move MAC address entry from list of pending
to list of active entries. Simple list_add_tail() leaves the entry
also in the first list, this leads to list corruption.

Cc: Rasesh Mody <rasesh.mody@qlogic.com>
Signed-off-by: default avatarIvan Vecera <ivecera@redhat.com>
Acked-by: default avatarRasesh Mody <rasesh.mody@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c44a72a5

drivers/net/ethernet/brocade/bna/bna_tx_rx.c

+1 −1
Original line number Diff line number Diff line
@@ -987,7 +987,7 @@ bna_rxf_ucast_cfg_apply(struct bna_rxf *rxf) 
	if (!list_empty(&rxf->ucast_pending_add_q)) {

		mac = list_first_entry(&rxf->ucast_pending_add_q,

				       struct bna_mac, qe);

		list_add_tail(&mac->qe, &rxf->ucast_active_q);

		list_move_tail(&mac->qe, &rxf->ucast_active_q);

		bna_bfi_ucast_req(rxf, mac, BFI_ENET_H2I_MAC_UCAST_ADD_REQ);

		return 1;

	}