Commit a7ea1992 authored Sep 20, 2011 by David Herrmann Committed by Matthew Garrett Oct 24, 2011

Platform: Fix error path in samsung-laptop init



samsung_init() should not return success if not all devices are initialized.
Otherwise, samsung_exit() will dereference sdev NULL pointers and others.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Matthew Garrett <mjg@redhat.com>

parent bee460be

drivers/platform/x86/samsung-laptop.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -781,7 +781,7 @@ static int __init samsung_init(void)
		sabi_iface = ioremap_nocache(ifaceP, 16);
		if (!sabi_iface) {
		pr_err("Can't remap %x\n", ifaceP);
		goto exit;
		goto error_no_signature;
		}
		if (debug) {
		printk(KERN_DEBUG "ifaceP = 0x%08x\n", ifaceP);
		@@ -833,7 +833,6 @@ static int __init samsung_init(void)
		if (retval)
		goto error_file_create;

		exit:
		return 0;

		error_file_create: