Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a6eed752 authored by Dan Carpenter's avatar Dan Carpenter Committed by Rafael J. Wysocki
Browse files

PM / OPP: passing NULL to PTR_ERR() 



The code was using PTR_ERR(NULL) which causes a static checker warning.
I have fixed up the printks and changed the return to -ENOENT.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent f59d3ee8

drivers/base/power/opp/cpu.c

+4 −5
Original line number Diff line number Diff line
@@ -223,8 +223,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask 
	/* Get OPP descriptor node */

	np = _of_get_opp_desc_node(cpu_dev);

	if (!np) {

		dev_dbg(cpu_dev, "%s: Couldn't find opp node: %ld\n", __func__,

			PTR_ERR(np));

		dev_dbg(cpu_dev, "%s: Couldn't find cpu_dev node.\n", __func__);

		return -ENOENT;

	}
@@ -247,9 +246,9 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask 
		/* Get OPP descriptor node */

		tmp_np = _of_get_opp_desc_node(tcpu_dev);

		if (!tmp_np) {

			dev_err(tcpu_dev, "%s: Couldn't find opp node: %ld\n",

				__func__, PTR_ERR(tmp_np));

			ret = PTR_ERR(tmp_np);

			dev_err(tcpu_dev, "%s: Couldn't find tcpu_dev node.\n",

				__func__);

			ret = -ENOENT;

			goto put_cpu_node;

		}