Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a57a46b9 authored by Alastair Bridgewater's avatar Alastair Bridgewater Committed by Takashi Iwai
Browse files

ALSA: hda/ca0132: Fix DMic data rate for Alienware M17x R4 



The commentary says to use various parameters, and lays out what
the mapping is...  The code used a 32KHz rate when the comment
says that it needs to use a 48KHz rate.  And this has been the
case since day one.

On the Alienware M17x R4, the DMic used to have exceptionally quiet
pickup and a lot of noise.  Changing the data rate fixes both of
these issues.

Searching the kernel bug tracker for ca0132-related issues shows no
mention of this being an issue for other hardware, and I have no
other hardware to test with, so a quirk is used to limit the effect
to just the M17x R4.

Signed-off-by: default avatarAlastair Bridgewater <alastair.bridgewater@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 5f8ddc6e

sound/pci/hda/patch_ca0132.c

+6 −1
Original line number Original line Diff line number Diff line
@@ -991,6 +991,7 @@ struct ca0132_spec { 
enum {

enum {

	QUIRK_NONE,

	QUIRK_NONE,

	QUIRK_ALIENWARE,

	QUIRK_ALIENWARE,

	QUIRK_ALIENWARE_M17XR4,

	QUIRK_SBZ,

	QUIRK_SBZ,

	QUIRK_R3DI,

	QUIRK_R3DI,

};

};
@@ -1040,6 +1041,7 @@ static const struct hda_pintbl r3di_pincfgs[] = { 
};

};





static const struct snd_pci_quirk ca0132_quirks[] = {

static const struct snd_pci_quirk ca0132_quirks[] = {

	SND_PCI_QUIRK(0x1028, 0x057b, "Alienware M17x R4", QUIRK_ALIENWARE_M17XR4),

	SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15 2015", QUIRK_ALIENWARE),

	SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15 2015", QUIRK_ALIENWARE),

	SND_PCI_QUIRK(0x1028, 0x0688, "Alienware 17 2015", QUIRK_ALIENWARE),

	SND_PCI_QUIRK(0x1028, 0x0688, "Alienware 17 2015", QUIRK_ALIENWARE),

	SND_PCI_QUIRK(0x1028, 0x0708, "Alienware 15 R2 2016", QUIRK_ALIENWARE),

	SND_PCI_QUIRK(0x1028, 0x0708, "Alienware 15 R2 2016", QUIRK_ALIENWARE),
@@ -6130,6 +6132,9 @@ static void ca0132_init_dmic(struct hda_codec *codec) 
	 * Bit   6: set to select Data2, clear for Data1

	 * Bit   6: set to select Data2, clear for Data1

	 * Bit   7: set to enable DMic, clear for AMic

	 * Bit   7: set to enable DMic, clear for AMic

	 */

	 */

	if (spec->quirk == QUIRK_ALIENWARE_M17XR4)

		val = 0x33;

	else

		val = 0x23;

		val = 0x23;

	/* keep a copy of dmic ctl val for enable/disable dmic purpuse */

	/* keep a copy of dmic ctl val for enable/disable dmic purpuse */

	spec->dmic_ctl = val;

	spec->dmic_ctl = val;