Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a311650a authored by Michael S. Tsirkin's avatar Michael S. Tsirkin
Browse files

virtio/ringtest: virtio_ring: fix up need_event math 



last kicked event index must be updated unconditionally:
even if we don't need to kick, we do not want to re-check
the same entry for events.

Reported-by: default avatarCornelia Huck <cohuck@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarJens Freimann <jfreimann@redhat.com>
parent f229a55c

tools/virtio/ringtest/virtio_ring_0_9.c

+14 −10
Original line number Diff line number Diff line
@@ -225,15 +225,17 @@ bool enable_call() 


void kick_available(void)

{

	bool need;



	/* Flush in previous flags write */

	/* Barrier C (for pairing) */

	smp_mb();

	if (!vring_need_event(vring_avail_event(&ring),

	need = vring_need_event(vring_avail_event(&ring),

				guest.avail_idx,

			      guest.kicked_avail_idx))

		return;

				guest.kicked_avail_idx);



	guest.kicked_avail_idx = guest.avail_idx;

	if (need)

		kick();

}
@@ -316,14 +318,16 @@ bool use_buf(unsigned *lenp, void **bufp) 


void call_used(void)

{

	bool need;



	/* Flush in previous flags write */

	/* Barrier D (for pairing) */

	smp_mb();

	if (!vring_need_event(vring_used_event(&ring),

	need = vring_need_event(vring_used_event(&ring),

				host.used_idx,

			      host.called_used_idx))

		return;

				host.called_used_idx);



	host.called_used_idx = host.used_idx;

	if (need)

		call();

}