Commit a1fee00d authored Oct 25, 2016 by Colin Ian King Committed by Rafael J. Wysocki Oct 27, 2016

PM / Domains: check for negative return from of_count_phandle_with_args()



The return from of_count_phandle_with_args can be negative, so we
should avoid kcalloc of a negative count of genpd_power_stat structs
by sanity checking if count is zero or less.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 411bf2a8

drivers/base/power/domain.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2113,7 +2113,7 @@ int of_genpd_parse_idle_states(struct device_node *dn,
		struct of_phandle_iterator it;

		count = of_count_phandle_with_args(dn, "domain-idle-states", NULL);
		if (!count)
		if (count <= 0)
		return -EINVAL;

		st = kcalloc(count, sizeof(*st), GFP_KERNEL);