Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1e7e636 authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Linus Torvalds
Browse files

PNP: workaround HP BIOS defect that leaves SMCF010 device partly enabled



Some HP/Compaq firmware reports via ACPI that the SMCF010 IR device is
enabled, but in fact, it leaves the device partly disabled.

HP nw8240 BIOS 68DTV Ver.  F.0F, released 9/15/2005 is one BIOS that has this
problem.

Signed-off-by: default avatarBjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Keith Owens <kaos@ocs.com.au>
Cc: Len Brown <lenb@kernel.org>
Cc: Adam Belay <ambx1@neo.rr.com>
Cc: Matthieu CASTET <castet.matthieu@free.fr>
Cc: Jean Tourrilhes <jt@hpl.hp.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Ville Syrjala <syrjala@sci.fi>
Cc: Russell King <rmk+serial@arm.linux.org.uk>
Cc: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 8f81dd14
Loading
Loading
Loading
Loading
+30 −0
Original line number Original line Diff line number Diff line
@@ -16,6 +16,7 @@
#include <linux/string.h>
#include <linux/string.h>
#include <linux/slab.h>
#include <linux/slab.h>
#include <linux/pnp.h>
#include <linux/pnp.h>
#include <linux/io.h>
#include "base.h"
#include "base.h"




@@ -106,6 +107,34 @@ static void quirk_sb16audio_resources(struct pnp_dev *dev)
	return;
	return;
}
}


static void quirk_smc_enable(struct pnp_dev *dev)
{
	unsigned int firbase;

	if (!dev->active || !pnp_port_valid(dev, 1))
		return;

	/*
	 * On the HP/Compaq nw8240 (and probably other similar machines),
	 * there is an SMCF010 device with two I/O port regions:
	 *
	 *	0x3e8-0x3ef SIR
	 *	0x100-0x10f FIR
	 *
	 * _STA reports the device is enabled, but in fact, the BIOS
	 * neglects to enable the FIR range.  Fortunately, it does fully
	 * enable the device if we call _SRS.
	 */
	firbase = pnp_port_start(dev, 1);
	if (inb(firbase + 0x7 /* IRCC_MASTER */) == 0xff) {
		pnp_err("%s (%s) enabled but not responding, disabling and "
			"re-enabling", dev->dev.bus_id, pnp_dev_name(dev));
		pnp_disable_dev(dev);
		pnp_activate_dev(dev);
	}
}


/*
/*
 *  PnP Quirks
 *  PnP Quirks
 *  Cards or devices that need some tweaking due to incomplete resource info
 *  Cards or devices that need some tweaking due to incomplete resource info
@@ -126,6 +155,7 @@ static struct pnp_fixup pnp_fixups[] = {
	{ "CTL0043", quirk_sb16audio_resources },
	{ "CTL0043", quirk_sb16audio_resources },
	{ "CTL0044", quirk_sb16audio_resources },
	{ "CTL0044", quirk_sb16audio_resources },
	{ "CTL0045", quirk_sb16audio_resources },
	{ "CTL0045", quirk_sb16audio_resources },
	{ "SMCf010", quirk_smc_enable },
	{ "" }
	{ "" }
};
};