Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a09759e8 authored by Vincent Abriou's avatar Vincent Abriou Committed by Daniel Vetter
Browse files

drm: remove useless parameters from drm_pick_cmdline_mode function 



drm_pick_cmdline_mode width and height parameters are useless.
Just remove them.

Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: default avatarVincent Abriou <vincent.abriou@st.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1483721084-20278-2-git-send-email-vincent.abriou@st.com
parent 9f547425

drivers/gpu/drm/drm_fb_helper.c

+3 −4
Original line number Diff line number Diff line
@@ -1752,8 +1752,7 @@ static bool drm_has_cmdline_mode(struct drm_fb_helper_connector *fb_connector) 
	return fb_connector->connector->cmdline_mode.specified;

}



struct drm_display_mode *drm_pick_cmdline_mode(struct drm_fb_helper_connector *fb_helper_conn,

						      int width, int height)

struct drm_display_mode *drm_pick_cmdline_mode(struct drm_fb_helper_connector *fb_helper_conn)

{

	struct drm_cmdline_mode *cmdline_mode;

	struct drm_display_mode *mode;
@@ -1871,7 +1870,7 @@ static bool drm_target_cloned(struct drm_fb_helper *fb_helper, 
		if (!enabled[i])

			continue;

		fb_helper_conn = fb_helper->connector_info[i];

		modes[i] = drm_pick_cmdline_mode(fb_helper_conn, width, height);

		modes[i] = drm_pick_cmdline_mode(fb_helper_conn);

		if (!modes[i]) {

			can_clone = false;

			break;
@@ -1993,7 +1992,7 @@ static bool drm_target_preferred(struct drm_fb_helper *fb_helper, 
			      fb_helper_conn->connector->base.id);



		/* got for command line mode first */

		modes[i] = drm_pick_cmdline_mode(fb_helper_conn, width, height);

		modes[i] = drm_pick_cmdline_mode(fb_helper_conn);

		if (!modes[i]) {

			DRM_DEBUG_KMS("looking for preferred mode on connector %d %d\n",

				      fb_helper_conn->connector->base.id, fb_helper_conn->connector->tile_group ? fb_helper_conn->connector->tile_group->id : 0);

drivers/gpu/drm/i915/intel_fbdev.c

+1 −1
Original line number Diff line number Diff line
@@ -447,7 +447,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper, 
			      connector->name);



		/* go for command line mode first */

		modes[i] = drm_pick_cmdline_mode(fb_conn, width, height);

		modes[i] = drm_pick_cmdline_mode(fb_conn);



		/* try for preferred next */

		if (!modes[i]) {

include/drm/drm_fb_helper.h

+1 −2
Original line number Diff line number Diff line
@@ -295,8 +295,7 @@ struct drm_display_mode * 
drm_has_preferred_mode(struct drm_fb_helper_connector *fb_connector,

			int width, int height);

struct drm_display_mode *

drm_pick_cmdline_mode(struct drm_fb_helper_connector *fb_helper_conn,

		      int width, int height);

drm_pick_cmdline_mode(struct drm_fb_helper_connector *fb_helper_conn);



int drm_fb_helper_add_one_connector(struct drm_fb_helper *fb_helper, struct drm_connector *connector);

int drm_fb_helper_remove_one_connector(struct drm_fb_helper *fb_helper,