Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a06b9a74 authored by Maarten Lankhorst's avatar Maarten Lankhorst Committed by Dave Airlie
Browse files

drm/mgag200: do not attempt to acquire a reservation while in an interrupt handler 



Mutexes should not be acquired in interrupt context. While the trylock
fastpath is arguably safe on all implementations, the slowpath
unlock path definitely isn't.

Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@canonical.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 19d4b72c

drivers/gpu/drm/mgag200/mgag200_fb.c

+3 −2
Original line number Diff line number Diff line
@@ -27,7 +27,7 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev, 
	struct mgag200_bo *bo;

	int src_offset, dst_offset;

	int bpp = (mfbdev->mfb.base.bits_per_pixel + 7)/8;

	int ret;

	int ret = -EBUSY;

	bool unmap = false;

	bool store_for_later = false;

	int x2, y2;
@@ -41,6 +41,7 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev, 
	 * then the BO is being moved and we should

	 * store up the damage until later.

	 */

	if (!in_interrupt())

		ret = mgag200_bo_reserve(bo, true);

	if (ret) {

		if (ret != -EBUSY)