Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a03f35ce authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf report tui: Fix multi event switching 



TAB/UNTAB were not hotkeys, so didn't exit hists__browse back to
hists__tui_browse_tree, allowing just the first event to be browsed.

Reported-by: default avatarWilliam Cohen <wcohen@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
Cc: William Cohen <wcohen@redhat.com>
LKML-Reference: <new-submission>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 69092624

tools/perf/util/ui/browsers/hists.c

+4 −1
Original line number Diff line number Diff line
@@ -292,7 +292,8 @@ static int hist_browser__run(struct hist_browser *self, const char *title) 
{

	int key;

	int exit_keys[] = { 'a', '?', 'h', 'C', 'd', 'D', 'E', 't',

			    NEWT_KEY_ENTER, NEWT_KEY_RIGHT, NEWT_KEY_LEFT, 0, };

			    NEWT_KEY_ENTER, NEWT_KEY_RIGHT, NEWT_KEY_LEFT,

			    NEWT_KEY_TAB, NEWT_KEY_UNTAB, 0, };



	self->b.entries = &self->hists->entries;

	self->b.nr_entries = self->hists->nr_entries;
@@ -859,6 +860,7 @@ int hists__browse(struct hists *self, const char *helpline, 
					"E         Expand all callchains\n"

					"d         Zoom into current DSO\n"

					"t         Zoom into current Thread\n"

					"TAB/UNTAB Switch events\n"

					"q/CTRL+C  Exit browser");

			continue;

		case NEWT_KEY_ENTER:
@@ -997,6 +999,7 @@ int hists__tui_browse_tree(struct rb_root *self, const char *help, int evidx) 
			if (nd == first)

				continue;

			nd = rb_prev(nd);

			break;

		default:

			return key;

		}