Commit 9f9831a8 authored Aug 25, 2012 by Julia Lawall Committed by Mauro Carvalho Chehab Sep 15, 2012

[media] drivers/media/platform/mx2_emmaprp.c: adjust inconsistent IS_ERR and PTR_ERR

Change the call to IS_ERR to test the value that was just initialized and
is returned using PTR_ERR.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression e,e1;
@@

(
if (IS_ERR(e)) { ... PTR_ERR(e) ... }
|
if (IS_ERR(e=e1)) { ... PTR_ERR(e) ... }
|
*if (IS_ERR(e))
 { ...
*  PTR_ERR(e1)
   ... }
)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Javier Martin <javier.martin@vista-silicon.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 3920631c

drivers/media/platform/mx2_emmaprp.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -906,9 +906,8 @@ static int emmaprp_probe(struct platform_device *pdev)
		}

		pcdev->clk_emma_ahb = devm_clk_get(&pdev->dev, "ahb");
		if (IS_ERR(pcdev->clk_emma_ipg)) {
		if (IS_ERR(pcdev->clk_emma_ahb))
		return PTR_ERR(pcdev->clk_emma_ahb);
		}

		irq_emma = platform_get_irq(pdev, 0);
		res_emma = platform_get_resource(pdev, IORESOURCE_MEM, 0);