Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f9115d8 authored by Clemens Ladisch's avatar Clemens Ladisch Committed by Takashi Iwai
Browse files

sound: oxygen: fix NULL pointer dereference when loading snd-oxygen 



Check that model->control_filter is set before trying to call it.

Signed-off-by: default avatarClemens Ladisch <clemens@ladisch.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 06651906

sound/pci/oxygen/oxygen_mixer.c

+7 −5
Original line number Diff line number Diff line
@@ -936,11 +936,13 @@ static int add_controls(struct oxygen *chip, 


	for (i = 0; i < count; ++i) {

		template = controls[i];

		if (chip->model->control_filter) {

			err = chip->model->control_filter(&template);

			if (err < 0)

				return err;

			if (err == 1)

				continue;

		}

		if (!strcmp(template.name, "Master Playback Volume") &&

		    chip->model->dac_tlv) {

			template.tlv.p = chip->model->dac_tlv;