Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e9ff4b7 authored by Sathya Perla's avatar Sathya Perla Committed by David S. Miller
Browse files

be2net: remove BUG_ON() in be_mcc_compl_is_new() 



The current code expects that the last word (with valid bit)
of an MCC compl is DMAed in one shot. This may not be the case.
Remove this assertion.

Signed-off-by: default avatarSathya Perla <sathya.perla@emulex.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 79876e03

drivers/net/ethernet/emulex/benet/be_cmds.c

+8 −5
Original line number Diff line number Diff line
@@ -93,14 +93,17 @@ static void be_mcc_notify(struct be_adapter *adapter) 
 * little endian) */

static inline bool be_mcc_compl_is_new(struct be_mcc_compl *compl)

{

	u32 flags;



	if (compl->flags != 0) {

		compl->flags = le32_to_cpu(compl->flags);

		BUG_ON((compl->flags & CQE_FLAGS_VALID_MASK) == 0);

		flags = le32_to_cpu(compl->flags);

		if (flags & CQE_FLAGS_VALID_MASK) {

			compl->flags = flags;

			return true;

	} else {

		return false;

		}

	}

	return false;

}



/* Need to reset the entire word that houses the valid bit */

static inline void be_mcc_compl_use(struct be_mcc_compl *compl)