Commit 9c563d20 authored Apr 17, 2009 by Jesse Brandeburg Committed by David S. Miller Apr 20, 2009

e1000e: indicate link down at load

As reported by Andrew Lutomirski <amluto@gmail.com>

All the intel wired ethernet drivers were calling netif_carrier_off
and netif_stop_queue (or variants) before calling register_netdevice

This is incorrect behavior as was pointed out by davem, and causes
ifconfig and friends to report a strange state before first link
after the driver was loaded, since without a netif_carrier_off, the stack
assumes carrier_on, but before register_netdev, netlink messages are not
sent out telling link state.

This apparently confused *some* versions of networkmanager.

Andy tested this for e1000e and confirmed it was working for him.

see thread: http://marc.info/?l=linux-netdev&m=123946479705636&w=2



Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andy Lutomirski <amluto@gmail.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b168dfc5

drivers/net/e1000e/netdev.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -3072,6 +3072,8 @@ static int e1000_open(struct net_device *netdev)
		if (test_bit(__E1000_TESTING, &adapter->state))
		return -EBUSY;

		netif_carrier_off(netdev);

		/* allocate transmit descriptors */
		err = e1000e_setup_tx_resources(adapter);
		if (err)
		@@ -5037,15 +5039,14 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
		if (!(adapter->flags & FLAG_HAS_AMT))
		e1000_get_hw_control(adapter);

		/* tell the stack to leave us alone until e1000_open() is called */
		netif_carrier_off(netdev);
		netif_tx_stop_all_queues(netdev);

		strcpy(netdev->name, "eth%d");
		err = register_netdev(netdev);
		if (err)
		goto err_register;

		/* carrier off reporting is important to ethtool even BEFORE open */
		netif_carrier_off(netdev);

		e1000_print_device_info(adapter);

		return 0;