Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9baddeb8 authored by Stanislaw Gruszka's avatar Stanislaw Gruszka Committed by David S. Miller
Browse files

bnx2x: change smp_mb() comment to conform the true 



Access to fp->tx_bp_prod is protected by __netif_tx_lock,
smp_mb() is not needed for that.

Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: default avatarEilon Greenstein <eilong@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0efc22f3

drivers/net/bnx2x_main.c

+5 −2
Original line number Diff line number Diff line
@@ -11428,9 +11428,12 @@ static netdev_tx_t bnx2x_start_xmit(struct sk_buff *skb, struct net_device *dev) 


	if (unlikely(bnx2x_tx_avail(fp) < MAX_SKB_FRAGS + 3)) {

		netif_tx_stop_queue(txq);

		/* We want bnx2x_tx_int to "see" the updated tx_bd_prod

		   if we put Tx into XOFF state. */



		/* paired memory barrier is in bnx2x_tx_int(), we have to keep

		 * ordering of set_bit() in netif_tx_stop_queue() and read of

		 * fp->bd_tx_cons */

		smp_mb();



		fp->eth_q_stats.driver_xoff++;

		if (bnx2x_tx_avail(fp) >= MAX_SKB_FRAGS + 3)

			netif_tx_wake_queue(txq);