Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a97ffd4 authored by Dan Carpenter's avatar Dan Carpenter Committed by Herbert Xu
Browse files

crypto: chcr - checking for IS_ERR() instead of NULL 



The create_hash_wr() function never returns error pointers.  It returns
NULL on error.

Fixes: 358961d1 ("crypto: chcr - Added new structure chcr_wr")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent b80609a1

drivers/crypto/chelsio/chcr_algo.c

+8 −9
Original line number Diff line number Diff line
@@ -956,9 +956,8 @@ static int chcr_ahash_update(struct ahash_request *req) 
	req_ctx->result = 0;

	req_ctx->data_len += params.sg_len + params.bfr_len;

	skb = create_hash_wr(req, &params);



	if (IS_ERR(skb))

		return PTR_ERR(skb);

	if (!skb)

		return -ENOMEM;



	if (remainder) {

		u8 *temp;
@@ -1021,8 +1020,8 @@ static int chcr_ahash_final(struct ahash_request *req) 
		params.more = 0;

	}

	skb = create_hash_wr(req, &params);

	if (IS_ERR(skb))

		return PTR_ERR(skb);

	if (!skb)

		return -ENOMEM;



	skb->dev = u_ctx->lldi.ports[0];

	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);
@@ -1072,8 +1071,8 @@ static int chcr_ahash_finup(struct ahash_request *req) 
	}



	skb = create_hash_wr(req, &params);

	if (IS_ERR(skb))

		return PTR_ERR(skb);

	if (!skb)

		return -ENOMEM;



	skb->dev = u_ctx->lldi.ports[0];

	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);
@@ -1123,8 +1122,8 @@ static int chcr_ahash_digest(struct ahash_request *req) 
	}



	skb = create_hash_wr(req, &params);

	if (IS_ERR(skb))

		return PTR_ERR(skb);

	if (!skb)

		return -ENOMEM;



	skb->dev = u_ctx->lldi.ports[0];

	set_wr_txq(skb, CPL_PRIORITY_DATA, ctx->tx_channel_id);