Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a0fee2b authored by Willem de Bruijn's avatar Willem de Bruijn Committed by David S. Miller
Browse files

sock_diag: do not broadcast raw socket destruction 



Diag intends to broadcast tcp_sk and udp_sk socket destruction.
Testing sk->sk_protocol for IPPROTO_TCP/IPPROTO_UDP alone is not
sufficient for this. Raw sockets can have the same type.

Add a test for sk->sk_type.

Fixes: eb4cb008 ("sock_diag: define destruction multicast groups")
Signed-off-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ab8ed951

include/linux/sock_diag.h

+6 −0
Original line number Diff line number Diff line
@@ -36,6 +36,9 @@ enum sknetlink_groups sock_diag_destroy_group(const struct sock *sk) 
{

	switch (sk->sk_family) {

	case AF_INET:

		if (sk->sk_type == SOCK_RAW)

			return SKNLGRP_NONE;



		switch (sk->sk_protocol) {

		case IPPROTO_TCP:

			return SKNLGRP_INET_TCP_DESTROY;
@@ -45,6 +48,9 @@ enum sknetlink_groups sock_diag_destroy_group(const struct sock *sk) 
			return SKNLGRP_NONE;

		}

	case AF_INET6:

		if (sk->sk_type == SOCK_RAW)

			return SKNLGRP_NONE;



		switch (sk->sk_protocol) {

		case IPPROTO_TCP:

			return SKNLGRP_INET6_TCP_DESTROY;