Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 99de6498 authored by Frank Rowand's avatar Frank Rowand Committed by Rob Herring
Browse files

OF: fix of_find_node_by_path() assumption that of_allnodes is root 



of_find_node_by_path() is borked because of_allnodes is not guaranteed to
contain the root of the tree after using any of the dynamic update functions
because some other nodes ends up as of_allnodes.

Fixes: c22e650e of: Make of_find_node_by_path() handle /aliases
Reported-by: default avatar <pantelis.antoniou@konsulko.com>
Signed-off-by: default avatarFrank Rowand <frank.rowand@sonymobile.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 28d3ee40

drivers/of/base.c

+2 −2
Original line number Diff line number Diff line
@@ -1961,9 +1961,9 @@ int of_attach_node(struct device_node *np) 


	raw_spin_lock_irqsave(&devtree_lock, flags);

	np->sibling = np->parent->child;

	np->allnext = of_allnodes;

	np->allnext = np->parent->allnext;

	np->parent->allnext = np;

	np->parent->child = np;

	of_allnodes = np;

	of_node_clear_flag(np, OF_DETACHED);

	raw_spin_unlock_irqrestore(&devtree_lock, flags);