Commit 9918f230 authored Sep 26, 2006 by Eric Sesterhenn Committed by David S. Miller Sep 28, 2006

[RTNETLINK]: Possible dereference in net/core/rtnetlink.c



another possible dereference spotted by coverity (#cid 1390).
if the nlmsg_parse() call fails, we goto errout, where we call
dev_put(), with dev still initialized to NULL.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 753ed90d

net/core/rtnetlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -562,7 +562,7 @@ static int rtnl_getlink(struct sk_buff skb, struct nlmsghdr nlh, void *arg)

		err = nlmsg_parse(nlh, sizeof(*ifm), tb, IFLA_MAX, ifla_policy);
		if (err < 0)
		goto errout;
		return err;

		ifm = nlmsg_data(nlh);
		if (ifm->ifi_index >= 0) {