Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98466cc4 authored by Stefan Richter's avatar Stefan Richter
Browse files

firewire: tone down some diagnostic log messages 

The "skipped bus generations" message was added together with the
respective fw_device retaining/ reviving code in order to see how it all
works out.  It did well, so don't spam the log anymore.

The "register access failure" situation still needs an actual handler.
But at this point it makes less sense to ask folks to send mails about
it.  We now have a pretty good picture of what controllers emit this and
when:

Texas Instruments PCIxx21 FireWire + CardBus + flash memory card
controller:
https://bugzilla.redhat.com/show_bug.cgi?id=608544

O2 Micro FireWire + flash memory card controller:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/801719
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/881688
http://marc.info/?l=linux1394-devel&m=132309283531423
http://marc.info/?l=linux1394-devel&m=132368567907469
http://marc.info/?l=linux1394-devel&m=132516165727468
http://marc.info/?l=linux1394-devel&m=133006486927699

Pinnacle Movieboard:
commit 7f7e3711
http://marc.info/?l=linux1394-devel&m=130714243325962



Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent c13ccfcf

drivers/firewire/core-topology.c

+0 −1
Original line number Diff line number Diff line
@@ -530,7 +530,6 @@ void fw_core_handle_bus_reset(struct fw_card *card, int node_id, int generation, 
	 */

	if (!is_next_generation(generation, card->generation) &&

	    card->local_node != NULL) {

		fw_notice(card, "skipped bus generations, destroying all nodes\n");

		fw_destroy_nodes(card);

		card->bm_retries = 0;

	}

drivers/firewire/ohci.c

+1 −2
Original line number Diff line number Diff line
@@ -2076,8 +2076,7 @@ static irqreturn_t irq_handler(int irq, void *data) 
	}



	if (unlikely(event & OHCI1394_regAccessFail))

		dev_err(ohci->card.device,

			"register access failure - please notify linux1394-devel@lists.sf.net\n");

		dev_err(ohci->card.device, "register access failure\n");



	if (unlikely(event & OHCI1394_postedWriteErr)) {

		reg_read(ohci, OHCI1394_PostedWriteAddressHi);