Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98051872 authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Kalle Valo
Browse files

mt76: fix possible NULL pointer dereferencing in mt76x2_mac_write_txwi() 



Verify wcid is not NULL before dereferencing the pointer to initialize
txwi rate/power info

Fixes: 7bc04215 ("mt76: add driver code for MT76x2e")
Signed-off-by: default avatarLorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 99ac5327

drivers/net/wireless/mediatek/mt76/mt76x2_mac.c

+1 −1
Original line number Diff line number Diff line
@@ -186,7 +186,7 @@ void mt76x2_mac_write_txwi(struct mt76x2_dev *dev, struct mt76x2_txwi *txwi, 
	txwi->pktid = 1;



	spin_lock_bh(&dev->mt76.lock);

	if (rate->idx < 0 || !rate->count) {

	if (wcid && (rate->idx < 0 || !rate->count)) {

		txwi->rate = wcid->tx_rate;

		max_txpwr_adj = wcid->max_txpwr_adj;

		nss = wcid->tx_rate_nss;