Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 979a459c authored by Xiongfeng Wang's avatar Xiongfeng Wang Committed by Jason Gunthorpe
Browse files

IB/cma: use strlcpy() instead of strncpy() 



gcc-8 reports

drivers/infiniband/core/cma_configfs.c: In function 'make_cma_dev':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 64 equals destination size [-Wstringop-truncation]

We need to use strlcpy() to make sure the string is nul-terminated.

Signed-off-by: default avatarXiongfeng Wang <xiongfeng.wang@linaro.org>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent a6532e71

drivers/infiniband/core/cma_configfs.c

+1 −1
Original line number Diff line number Diff line
@@ -295,7 +295,7 @@ static struct config_group *make_cma_dev(struct config_group *group, 
		goto fail;

	}



	strncpy(cma_dev_group->name, name, sizeof(cma_dev_group->name));

	strlcpy(cma_dev_group->name, name, sizeof(cma_dev_group->name));



	config_group_init_type_name(&cma_dev_group->ports_group, "ports",

				    &cma_ports_group_type);