Commit 978e55d2 authored Jan 02, 2014 by Hauke Mehrtens Committed by Ralf Baechle Jan 24, 2014

bcma: prevent irq handler from firing when registered



With this patch we prevent the irq from being fired when it is
registered. The Hardware fires an IRQ when input signal XOR polarity
AND gpio mask is 1. Now we are setting polarity to a vlaue so that is
is 0 when we register it.

In addition we also set the irq mask register to 0 when the irq handler
is initialized, so all gpio irqs are masked and there will be no
unexpected irq.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Tested-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: John Crispin <blogic@openwrt.org>
Patchwork: http://patchwork.linux-mips.org/patch/6304/

parent 17d97bad

drivers/bcma/driver_gpio.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -91,7 +91,9 @@ static void bcma_gpio_irq_unmask(struct irq_data *d)
		{
		struct bcma_drv_cc *cc = irq_data_get_irq_chip_data(d);
		int gpio = irqd_to_hwirq(d);
		u32 val = bcma_chipco_gpio_in(cc, BIT(gpio));

		bcma_chipco_gpio_polarity(cc, BIT(gpio), val);
		bcma_chipco_gpio_intmask(cc, BIT(gpio), BIT(gpio));
		}

		@@ -156,6 +158,7 @@ static int bcma_gpio_irq_domain_init(struct bcma_drv_cc *cc)
		if (err)
		goto err_req_irq;

		bcma_chipco_gpio_intmask(cc, ~0, 0);
		bcma_cc_set32(cc, BCMA_CC_IRQMASK, BCMA_CC_IRQ_GPIO);

		return 0;