Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9761a246 authored by Dan Carpenter's avatar Dan Carpenter Committed by Anna Schumaker
Browse files

sunrpc: silence uninitialized variable warning 



kstrtouint() can return a couple different error codes so the check for
"ret == -EINVAL" is wrong and static analysis tools correctly complain
that we can use "num" without initializing it.  It's not super harmful
because we check the bounds.  But it's also easy enough to fix.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 251af29c

net/sunrpc/xprtsock.c

+3 −1
Original line number Diff line number Diff line
@@ -3261,7 +3261,9 @@ static int param_set_uint_minmax(const char *val, 
	if (!val)

		return -EINVAL;

	ret = kstrtouint(val, 0, &num);

	if (ret == -EINVAL || num < min || num > max)

	if (ret)

		return ret;

	if (num < min || num > max)

		return -EINVAL;

	*((unsigned int *)kp->arg) = num;

	return 0;