Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97202bbe authored by Jason Gunthorpe's avatar Jason Gunthorpe
Browse files

IB/uverbs: Do not use uverbs_cmd_mask in the ioctl path 



Instead we are now checking the function pointers directly. Get rid of
both cases in ioctl and drop the nonsense idea that destroy can fail.

Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
parent 60e6627f

drivers/infiniband/core/uverbs_std_types_cq.c

+1 −4
Original line number Diff line number Diff line
@@ -70,7 +70,7 @@ static int UVERBS_HANDLER(UVERBS_METHOD_CQ_CREATE)(struct ib_device *ib_dev, 
	struct ib_uverbs_completion_event_file    *ev_file = NULL;

	struct ib_uobject *ev_file_uobj;



	if (!(ib_dev->uverbs_cmd_mask & 1ULL << IB_USER_VERBS_CMD_CREATE_CQ))

	if (!ib_dev->create_cq || !ib_dev->destroy_cq)

		return -EOPNOTSUPP;



	ret = uverbs_copy_from(&attr.comp_vector, attrs,
@@ -185,9 +185,6 @@ static int UVERBS_HANDLER(UVERBS_METHOD_CQ_DESTROY)(struct ib_device *ib_dev, 


	obj = container_of(uobj, struct ib_ucq_object, uobject);



	if (!(ib_dev->uverbs_cmd_mask & 1ULL << IB_USER_VERBS_CMD_DESTROY_CQ))

		return -EOPNOTSUPP;



	ret = rdma_explicit_destroy(uobj);

	if (ret)

		return ret;