Commit 96050dfb authored Jun 09, 2009 by Peter Botha Committed by Linus Torvalds Jun 09, 2009

char: mxser, fix ISA board lookup



There's a bug in the mxser kernel module that still appears in the
2.6.29.4 kernel.

mxser_get_ISA_conf takes a ioaddress as its first argument, by passing the
not of the ioaddr, you're effectively passing 0 which means it won't be
able to talk to an ISA card.  I have tested this, and removing the !
fixes the problem.

Cc: "Peter Botha" <peterb@goldcircle.co.za>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a61d90d7

drivers/char/mxser.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2711,7 +2711,7 @@ static int __init mxser_module_init(void)
	continue;		continue;

	brd = &mxser_boards[m];		brd = &mxser_boards[m];
	retval = mxser_get_ISA_conf(!ioaddr[b], brd);		retval = mxser_get_ISA_conf(ioaddr[b], brd);
	if (retval <= 0) {		if (retval <= 0) {
	brd->info = NULL;		brd->info = NULL;
	continue;		continue;