Commit 95e72fba authored Apr 27, 2017 by Tobin C. Harding Committed by Greg Kroah-Hartman Apr 28, 2017

staging: ks7010: clean memory allocation



Memory allocation code contains unneeded debug statements, failed
kmalloc() calls typically do not require a debug message. Introduction
of a local 'size' variable allows kmalloc() call to be marginally
cleaner, still uses magic numbers but these require a more substantial
fix. Moving the magic numbers onto a single line opens the way for
further refactoring.

Clean memory allocation code, remove debug statements.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8215fc60

drivers/staging/ks7010/ks_hostif.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -1135,12 +1135,9 @@ int hostif_data_request(struct ks_wlan_private priv, struct sk_buff skb)
		netif_stop_queue(priv->net_dev);
		}

		DPRINTK(4, "skb_buff length=%d\n", skb_len);
		pp = kmalloc(hif_align_size(sizeof(*pp) + 6 + skb_len + 8),
		KS_WLAN_MEM_FLAG);

		size = sizeof(*pp) + 6 + skb_len + 8;
		pp = kmalloc(hif_align_size(size), KS_WLAN_MEM_FLAG);
		if (!pp) {
		DPRINTK(3, "allocate memory failed..\n");
		ret = -ENOMEM;
		goto err_kfree_skb;
		}